docs: make a note regarding i18n messageIdFormat#67858
Open
BodyCount wants to merge 1 commit intoangular:mainfrom
Open
docs: make a note regarding i18n messageIdFormat#67858BodyCount wants to merge 1 commit intoangular:mainfrom
BodyCount wants to merge 1 commit intoangular:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Hi, thanks for your contribution Could you amend the message to something like
to follow the commit message guidelines |
Author
|
Updated commit message to follow guidelines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Make a clear statement that angular compiler option
enableI18nLegacyMessageIdFormathas no effect when used with@angular/build:applicationbundlerOther information
Option use in webpack builder - useLegacyIds = wco.tsConfig.options.enableI18nLegacyMessageIdFormat ?? true;
So I spent quite a few hours today trying to migrate application to angular 20 and it was hard to troubleshoot why IDs are being changed when
extract-i18nis executed and how can I not lost project translations. Docs highlight that one can useenableI18nLegacyMessageIdFormatfor backwards compatibility with old i18n ids (which were sha-like I believe).But it is partially true - because the option itself works only with
@angular-devkit/build-angularwebpack bundler. Hope this note will help someone