fix(adev): reset webcontainer counter when webcontainer crashes#67844
Open
cyphercodes wants to merge 1 commit intoangular:mainfrom
Open
fix(adev): reset webcontainer counter when webcontainer crashes#67844cyphercodes wants to merge 1 commit intoangular:mainfrom
cyphercodes wants to merge 1 commit intoangular:mainfrom
Conversation
When the webcontainer crashes (e.g., out of memory error), the counter was not being reset. This caused the counter to keep increasing on page refreshes, eventually showing the user a warning about too many webcontainers even when there was only one active instance. This fix adds a decreaseInstancesCounter method to AlertManager and calls it when setErrorState is invoked, ensuring the counter accurately reflects the number of active webcontainer instances. Fixes angular#52647
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When the webcontainer crashes (e.g., out of memory error), the counter was not being reset. This caused the counter to keep increasing on page refreshes, eventually showing the user a warning about too many webcontainers even when there was only one active instance.
Issue Number: #52647
What is the new behavior?
This fix adds a
decreaseInstancesCounter()method toAlertManagerand calls it whensetErrorStateis invoked, ensuring the counter accurately reflects the number of active webcontainer instances.Does this PR introduce a breaking change?
Other information
This fix ensures that when a webcontainer crashes and the user refreshes the page, the counter is properly decremented so the user doesn't get a false warning about having too many webcontainers open.