Skip to content

Pin rust-toolchain action to a commit hash - part 1#7500

Merged
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:rust-toolchain-pin-hash-0
Mar 25, 2026
Merged

Pin rust-toolchain action to a commit hash - part 1#7500
youknowone merged 1 commit intoRustPython:mainfrom
ShaharNaveh:rust-toolchain-pin-hash-0

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Mar 24, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated CI workflow configuration for improved build consistency and reliability.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 24, 2026
View reviewed changes
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ab45d1cb-d79d-4493-ad67-23da5e7051d7

📥 Commits

Reviewing files that changed from the base of the PR and between 82432be and 980e36b.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml
📝 Walkthrough

Walkthrough

Updated GitHub Actions CI workflow to pin the dtolnay/rust-toolchain action to a specific commit hash instead of floating tags, and added explicit toolchain: stable parameters to relevant jobs. The miri job retains its dynamic nightly channel configuration.

Changes

Cohort / File(s) Summary
CI Toolchain Pinning
.github/workflows/ci.yaml		 Pinned dtolnay/rust-toolchain action to commit efa25f7f19611383d5b0ccf2d1c8914531636bf9 across multiple jobs. Added explicit with: toolchain: stable inputs to clippy and wasm/stable check jobs. Miri job updated to use pinned action commit while preserving toolchain: ${{ env.NIGHTLY_CHANNEL }} dynamic selection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

🐰 A rabbit pins down the toolchain's spring,
No more shall versions dance and fling!
Stable, locked, and miri bright,
CI workflows flow just right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: pinning the rust-toolchain action to a commit hash rather than using floating tags.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh force-pushed the rust-toolchain-pin-hash-0 branch from 899b2de to 980e36b Compare March 24, 2026 12:53
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 24, 2026
View reviewed changes
.github/workflows/ci.yaml
persist-credentials: false

- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
.github/workflows/ci.yaml
gcc-aarch64-linux-gnu: ${{ matrix.dependencies.gcc-aarch64-linux-gnu || false }}

- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
.github/workflows/ci.yaml
persist-credentials: false

- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@efa25f7f19611383d5b0ccf2d1c8914531636bf9

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
.github/workflows/ci.yaml
@@ -413,7 +418,9 @@ jobs:

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
.github/workflows/ci.yaml
@@ -485,9 +492,10 @@ jobs:
with:

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
.github/workflows/ci.yaml
target: wasm32-wasip1
toolchain: stable

- uses: Swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
.github/workflows/ci.yaml Outdated

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
@youknowone youknowone merged commit 6db7910 into RustPython:main Mar 25, 2026
18 checks passed
Copilot AI pushed a commit that referenced this pull request Mar 25, 2026
@ShaharNaveh
Pin rust-toolchain action to a commit hash (#7500)
1825015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShaharNaveh @youknowone