[VM] Object pickling implementation for product object (python itertools) #5089
Merged
youknowone merged 4 commits intoRustPython:mainfrom Oct 12, 2023
Merged
[VM] Object pickling implementation for product object (python itertools) #5089youknowone merged 4 commits intoRustPython:mainfrom
youknowone merged 4 commits intoRustPython:mainfrom
Conversation
27 tasks
youknowone
reviewed
Oct 11, 2023
vm/src/stdlib/itertools.rs
Outdated
| r: AtomicCell<usize>, // Size of result tuple | ||
| exhausted: AtomicCell<bool>, // Set when the iterator is exhausted | ||
| pool: Vec<PyObjectRef>, | ||
| // Collected input iterable |
Member
There was a problem hiding this comment.
The comment place here is looking weird. Isn't this expected to be put on upper line?
Contributor
Author
There was a problem hiding this comment.
Hi,
Thanks for response,
Yeah, actually I am not sure how this is getting formatted (maybe because of my IDE).
Anyway will fix it and push this.
Now Ran (cargo fmt -all)
Contributor
Author
There was a problem hiding this comment.
some tests are failing after this formatting, But I don't think, it is related to this change(formatting comments).
Is it possible to run tests again?
youknowone
approved these changes
Oct 12, 2023
Member
youknowone
left a comment
There was a problem hiding this comment.
Thank you! The test is looking flaky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
#3611