Implement itertools.accumulate.__reduce__ and __setstate__#4434
Merged
youknowone merged 2 commits intoRustPython:mainfrom Jun 12, 2023
Merged
Implement itertools.accumulate.__reduce__ and __setstate__#4434youknowone merged 2 commits intoRustPython:mainfrom
youknowone merged 2 commits intoRustPython:mainfrom
Conversation
Contributor
|
Is this related to #3611? |
27 tasks
Member
|
Because you fixed related bug from the test suites, you can remove |
Contributor
|
cc @Snowapril |
0de70f9 to
e918d56
Compare
e918d56 to
dd469e2
Compare
youknowone
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add accumulate.reduce implementation for #3611.
Publishing as a draft to collect initial feedback. Behaviour seems to be identical to CPython's, but I'm still testing.
Relevant links