Merged
Conversation
Sync the remote fork with upstream and pull to local branch
Member
|
Search for |
Contributor
Author
|
I added How it works with Python 3: How it works with this implementation: |
27 tasks
Contributor
Author
|
The solution was to implement |
Contributor
|
@Snowapril you may be interested in this |
youknowone
requested changes
Oct 21, 2022
Member
youknowone
left a comment
There was a problem hiding this comment.
Looks good! I left a few suggestions about style and locks.
vm/src/stdlib/itertools.rs
Outdated
Comment on lines
+68
to
+76
| match source { | ||
| Some(source) => match active { | ||
| Some(active) => { | ||
| Ok(vm.new_tuple((cls, vm.ctx.empty_tuple.clone(), (source, active)))) | ||
| } | ||
| None => Ok(vm.new_tuple((cls, vm.ctx.empty_tuple.clone(), (source,)))), | ||
| }, | ||
| None => Ok(vm.new_tuple((cls, vm.ctx.empty_tuple.clone()))), | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| match source { | |
| Some(source) => match active { | |
| Some(active) => { | |
| Ok(vm.new_tuple((cls, vm.ctx.empty_tuple.clone(), (source, active)))) | |
| } | |
| None => Ok(vm.new_tuple((cls, vm.ctx.empty_tuple.clone(), (source,)))), | |
| }, | |
| None => Ok(vm.new_tuple((cls, vm.ctx.empty_tuple.clone()))), | |
| } | |
| let empty_tuple = vm.ctx.empty_tuple.clone(); | |
| let reduced = match source { | |
| Some(source) => match active { | |
| Some(active) => vm.new_tuple((cls, empty_tuple, (source, active))), | |
| None => vm.new_tuple((cls, empty_tuple, (source,))), | |
| }, | |
| None => vm.new_tuple((cls, empty_tuple)), | |
| }; | |
| Ok(reduced) |
vm/src/stdlib/itertools.rs
Outdated
Comment on lines
+103
to
+104
| *zelf.source.write() = source.to_owned().try_into_value(vm)?; | ||
| *zelf.active.write() = active.to_owned().try_into_value(vm)?; |
Member
There was a problem hiding this comment.
To avoid unpleasure broken synchronization, locking both and writing will be better.
Suggested change
| *zelf.source.write() = source.to_owned().try_into_value(vm)?; | |
| *zelf.active.write() = active.to_owned().try_into_value(vm)?; | |
| let mut source_lock = zelf.source.write(); | |
| let mut active_lock = zelf.active.write(); | |
| *source_lock = source.to_owned().try_into_value(vm)?; | |
| *active_lock = active.to_owned().try_into_value(vm)?; |
youknowone
approved these changes
Oct 21, 2022
Member
|
Thank you for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I tried to implement the
reducemethod forPyItertoolsChain(issue #3611) but got stuck. I used the CPython implementation as a reference. The implementation seems to work just fine with simple arrays etc. but fails thetest_chain_reducibletest. Any suggestions on why?The error message: