Skip to content

Update packaging script to build reference assembly targeting netcoreapp2.1 and use actual .csproj files#8729

Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
daxian-dbw:refassembly
Jan 25, 2019
Merged

Update packaging script to build reference assembly targeting netcoreapp2.1 and use actual .csproj files#8729
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
daxian-dbw:refassembly

Conversation

@daxian-dbw
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw commented Jan 24, 2019

PR Summary

Update packaging script to build reference assembly targeting netcoreapp2.1 and use actual .csproj files.
Fix #8721

PR Context

PR Checklist

Comment thread tools/packaging/projects/reference/System.Management.Automation.csproj Outdated
Comment thread tools/packaging/projects/reference/System.Management.Automation.csproj Outdated
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 24, 2019
@daxian-dbw
Copy link
Copy Markdown
Member Author

Verified by build https://mscodehub.visualstudio.com/PowerShellCore/_build%2Fresults?buildId=72005&_a=summary
Build passed and the generated nuget packages are also manually verified.

@TravisEz13
Copy link
Copy Markdown
Member

We may need to tell dependabot to rescan the repo after this is merged.

@adityapatwardhan adityapatwardhan merged commit 1264a00 into PowerShell:master Jan 25, 2019
@daxian-dbw daxian-dbw deleted the refassembly branch January 26, 2019 10:21
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request May 14, 2019
…eapp2.1` and use actual `.csproj` files (PowerShell#8729)

# Conflicts:
#	tools/packaging/packaging.psm1
#	tools/packaging/packaging.strings.psd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check in the .csproj files that are used to build reference assemblies for our SDK nuget packages

3 participants