ModuleCmdletBase: Use Path.Combine instead of + "\\" to append a ps1xml path#27038
Open
powercode wants to merge 1 commit intoPowerShell:masterfrom
Open
ModuleCmdletBase: Use Path.Combine instead of + "\\" to append a ps1xml path#27038powercode wants to merge 1 commit intoPowerShell:masterfrom
powercode wants to merge 1 commit intoPowerShell:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an OS-specific path separator bug when synthesizing a “resolved” ps1xml path under $PSHOME (or an alternate PSHome-adjacent directory) during module manifest processing, which could otherwise yield Windows-style \ separators on non-Windows systems.
Changes:
- Replace manual string concatenation (
psHome + "\\" + ...) withPath.Combine(psHome, ...)when constructing the fallback ps1xml path.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
There is an edge case when testing binary modules on Linux, where we get into the code path
The fix is
This causes the module load to fail because the engine tries to load types and formats from
somepath/bin\Module.formats.ps1xml. Note the backslash.PR Context
I've only seen this in unit tests hosting PowerShell, hosting powershell.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header