Respect -Shuffle:$false in Get-SecureRandom#26460
Merged
iSazonov merged 1 commit intoPowerShell:masterfrom Nov 17, 2025
Merged
Conversation
Collaborator
|
@yotsuda Please rebase to get related fix. |
5343300 to
6704c3f
Compare
iSazonov
approved these changes
Nov 17, 2025
20 tasks
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
kilasuit
pushed a commit
to kilasuit/PowerShell
that referenced
this pull request
Jan 2, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds a test case for
Get-SecureRandomto verify the fix for-Shuffle:$falsehandling. The underlying issue was already fixed in PR #26457, which corrected the base classGetRandomCommandBasethatGet-SecureRandominherits from.Fixes #26458
Related to #25242
PR Context
The cmdlet
Get-SecureRandominherits fromGetRandomCommandBase, which was fixed in PR #26457 to correctly handle explicit-Shuffle:$falseparameter values. Since the fix was made in the base class, it automatically applies toGet-SecureRandomas well.This PR adds a test case to ensure the fix works correctly for
Get-SecureRandom.Changes
Get-SecureRandom.Tests.ps1: "Should return a single random item when -Shuffle:$false is used"Testing
-Shuffle:$falsereturns exactly one item from the input collectionPR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header