Fix CA1846 and CA1845 for using AsSpan instead of Substring#15738
Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom Jul 9, 2021
Merged
Fix CA1846 and CA1845 for using AsSpan instead of Substring#15738adityapatwardhan merged 3 commits intoPowerShell:masterfrom
AsSpan instead of Substring#15738adityapatwardhan merged 3 commits intoPowerShell:masterfrom
Conversation
SteveL-MSFT
reviewed
Jul 7, 2021
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
SteveL-MSFT
reviewed
Jul 7, 2021
daxian-dbw
approved these changes
Jul 7, 2021
Member
daxian-dbw
left a comment
There was a problem hiding this comment.
Look good other than what Steve already pointed out.
Collaborator
|
I think it makes sense to add the rules in |
…letionCompleters.cs Co-authored-by: Steve Lee <slee@microsoft.com>
Co-authored-by: Steve Lee <slee@microsoft.com>
SteveL-MSFT
approved these changes
Jul 9, 2021
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix CA1846 and CA1845 violations by replacing Substring with AsSpan.
PR Context
These violations cause build break when used with .NET 6 Preview 6.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).