Remove PSDesiredStateConfiguration v2.0.5 module#15536
Merged
TravisEz13 merged 5 commits intoPowerShell:masterfrom Jun 9, 2021
Merged
Remove PSDesiredStateConfiguration v2.0.5 module#15536TravisEz13 merged 5 commits intoPowerShell:masterfrom
PSDesiredStateConfiguration v2.0.5 module#15536TravisEz13 merged 5 commits intoPowerShell:masterfrom
Conversation
anmenaga
commented
Jun 7, 2021
| # Make sure ExperimentalFeatures from modules in PSHome are added | ||
| # https://github.com/PowerShell/PowerShell/issues/10550 | ||
| @("PSDesiredStateConfiguration.InvokeDscResource") | ForEach-Object { | ||
| $ExperimentalFeaturesFromGalleryModulesInPSHome = @() |
Author
There was a problem hiding this comment.
The PSDesiredStateConfiguration.InvokeDscResource exp.feature is no longer there - that is intentional, but I don't want to get rid of this code because it might be useful in the future to other modules, so leaving just empty array here.
added 2 commits
June 7, 2021 14:45
bagajjal
reviewed
Jun 7, 2021
test/powershell/engine/ExperimentalFeature/Get-ExperimentalFeature.Tests.ps1
Outdated
Show resolved
Hide resolved
Collaborator
|
I added Documentation-Needed label - I think we need to clearly document this in release documentation. If you agree please open new issue in PowerShell-Docs repository. I don't think a blog post is enough. |
Author
|
Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a |
bagajjal
approved these changes
Jun 9, 2021
TravisEz13
approved these changes
Jun 9, 2021
PSDesiredStateConfiguration v2.0.5 module
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently
PSDesiredStateConfiguration v2.0.5module ships inbox with PS releases.This module is now published on PS Gallery and should be installed from PS Gallery when necessary by something like
Install-Module -Name PSDesiredStateConfiguration -Repository PSGallery -MaximumVersion 2.99.This PR removes v2.0.5 module from being shipped in future PS releases.
Context: Announcing PSDesiredStateConfiguration on PowerShell Gallery.
Special case worth mentioning: this PR removes
PSDesiredStateConfiguration.InvokeDscResourceexperimental feature from being enabled by default in future PS Previews (because the module will no longer be shipped with them). This means that users who need that functionality will have to enable this experimental feature after downloading the module from PS Gallery.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).