feat: overhaul and streamline Android page navigation transitions#7925
Merged
feat: overhaul and streamline Android page navigation transitions#7925
Conversation
Extract TabFragmentImplementation in tab-navigation base for both tabs and bottom navigation
2b3631d to
99f477c
Compare
d79fadd to
d17e710
Compare
d17e710 to
da2e8a8
Compare
Contributor
|
test --ignore tests_app_transitions api23 ios12 |
Contributor
Author
|
test --ignore tests_app_transitions api23 |
Contributor
Author
|
test --ignore ngapps_android animations_android api23 api28 |
Contributor
Author
|
test --ignore ngapps_android#djenkov/comment-tests api23 api28 |
manoldonev
reviewed
Oct 15, 2019
manoldonev
reviewed
Oct 15, 2019
...modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/CustomTransition.java
Show resolved
Hide resolved
manoldonev
reviewed
Oct 15, 2019
...modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/CustomTransition.java
Outdated
Show resolved
Hide resolved
manoldonev
reviewed
Oct 15, 2019
...modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/CustomTransition.java
Outdated
Show resolved
Hide resolved
manoldonev
reviewed
Oct 15, 2019
tns-core-modules/ui/bottom-navigation/bottom-navigation.android.ts
Outdated
Show resolved
Hide resolved
manoldonev
reviewed
Oct 15, 2019
tns-core-modules/ui/bottom-navigation/bottom-navigation.android.ts
Outdated
Show resolved
Hide resolved
manoldonev
reviewed
Oct 15, 2019
...modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/CustomTransition.java
Outdated
Show resolved
Hide resolved
manoldonev
reviewed
Oct 15, 2019
...modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/CustomTransition.java
Show resolved
Hide resolved
manoldonev
reviewed
Oct 15, 2019
...modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/CustomTransition.java
Show resolved
Hide resolved
manoldonev
reviewed
Oct 15, 2019
| const bitmap = android.graphics.Bitmap.createBitmap(view.getDrawingCache()); | ||
| view.setDrawingCacheEnabled(false); | ||
|
|
||
| return bitmap; |
Contributor
There was a problem hiding this comment.
Can this return null? Would new android.graphics.drawable.BitmapDrawable(appResources, null) throw an exception?
manoldonev
reviewed
Oct 15, 2019
manoldonev
reviewed
Oct 15, 2019
manoldonev
reviewed
Oct 15, 2019
| } | ||
|
|
||
| private loadBitmapFromView(view: android.view.View): android.graphics.Bitmap { | ||
| // Another way to get view bitmap. Test performance vs setDrawingCacheEnabled |
Contributor
There was a problem hiding this comment.
Unify with the other implementation
manoldonev
approved these changes
Oct 15, 2019
Contributor
Author
|
test --ignore tsapps_android tscapps ngapps_android api23 api28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue