Clean up existing install/symlink before extracting .mpk#55
Merged
ThomasFarstrike merged 1 commit intoMicroPythonOS:mainfrom Feb 21, 2026
Merged
Conversation
install_mpk() would fail with EEXIST if the destination folder already existed from a previous (possibly partial) install, or if a dangling symlink occupied the path (e.g. a dev symlink whose target was removed). Before extracting, now remove the destination if it is: - A real directory (via shutil.rmtree) - A regular file (via os.remove) - A symlink, including broken ones (via os.remove as a fallback) This enables clean reinstalls, updates, and recovery from failed installs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Awesome, you are now officially a MicroPythonOS contributor!!! |
Contributor
Author
|
Thank you @ThomasFarstrike I can't believe it! It feels like winning the lottery 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_mpk()now removes the destination folder before extracting, preventing[Errno 17] EEXISTfailuresshutil.rmtree), regular files, and symlinks including broken/dangling ones (viaos.remove)apps/com.example.app -> ../../SomeProject/) blocks installation when the symlink target doesn't existTest plan
🤖 Generated with Claude Code