fixed bug where clicking in swipe areas was ignored#11
fixed bug where clicking in swipe areas was ignored#11ThomasFarstrike merged 1 commit intoMicroPythonOS:mainfrom
Conversation
Added a short movement detection for back_swipe and top_swipe because otherwise clicks in these areas where ignored. Since I (Quasi Kili) couldn't type the Q on the new mpos_keyboard on an esp32 touchscreen this was an urgent issue. You can test the before and after by clicking on the leftmost part of the q key in the wifi app or the upper bar in the connect 4 app. Sending pressed AND clicked AND released events to the object below might not be the cleanest solution, but the simplest and most universal.
|
Thanks! But how does that relate to this commit ? Are you sure you were testing with the latest code so that you had that latest commit included? I just wonder whether this modification still necessary... probably yes? |
|
Without this proposed change, I was often able to click in those swipe areas, but not always consistently. Was that because "0 movement" was treated as a click but "short movement" was ignored? |
|
I don't think this has anything to do with the keyboard code. The zones for swiping are lv objects on top, and are blocking now, if i understand correctly. |
|
Video of the issue and the fix: without_fix.movwith_fix.mov |
|
Impressive video making skills! Awesome to see this finally fixed. I had no idea how to tackle it. Thank you! |
|
Perhaps this finally opens up the possibility to increase the size of those swipe areas a bit, so that swipes are more easily detected. Currently you have to swipe pretty slowly, to avoid "starting" the swipe outside of the swipe area... |
It can be a bit bigger, but we must make sure it does not close the door for useful swipes in apps. Right now it also shows the back button on a tap. If the area is bigger this "hint" will become annoying. We could fade or slide it in while you are swiping, but then it is not a real hint anymore. In the end I think a slow back swipe is fine. |
Added a short movement detection for back_swipe and top_swipe because otherwise clicks in these areas where ignored. Since I (Quasi Kili) couldn't type the Q on the new mpos_keyboard on an esp32 touchscreen this was an urgent issue. You can test the before and after by clicking on the leftmost part of the q key in the wifi app or the upper bar in the connect 4 app. Sending pressed AND clicked AND released events to the object below might not be the cleanest solution, but the simplest and most universal.