refactor(stylehelper): add generic state stylesheet composer#11
Open
refactor(stylehelper): add generic state stylesheet composer#11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
QelStyleHelperfrom becoming a collection of per-component state-sheet functions by providing a reusable composer for common visual states.QelThemeremain the single source of token ownership whileQelStyleHelperoffers generic primitives to derive QSS for any component.*StateStyleSheetfunction; components should only map theme tokens into a reusable state set.Description
ButtonStylewith a genericComponentStyleand addStateStyleSetto represent the six common visual states (normal,hover,active,focus,disabled,loading).composeStateStyleSheet(const QString &baseSelector, const QString &loadingSelector, const StateStyleSet &styles, bool disableFocusOutline)to generate standard state QSS for arbitrary component selectors.buttonStateStyles(...)to map button theme tokens into aStateStyleSetand keepbuttonStateStyleSheet(...)as a thin wrapper that calls the generic composer for backward compatibility.QelButton::updateButtonStyle()to useQelStyleHelper::buttonStateStyleSheet(...)for state QSS while retaining geometry/size/border-radius logic inside the component.Testing
qmake QelButton/QelButton.pro -o /tmp/QelButton.Makefile && make -f /tmp/QelButton.Makefile -j2and the command failed becauseqmakeis not installed in the environment (command not found).QelButtonnow delegates state stylesheet composition to the helper and that the helper provides the generic composer; no runtime artifacts were produced due to the missingqmaketool.Codex Task