Conversation
== has higher precedence than &, so the macro evaluated as (flags) & ((flag) == 0) instead of ((flags) & (flag)) == 0.
…tion on add failure
…Set null in tdbPagerAbort
…in tdbRealloc, header guard order, variable shadowing
…t buffer on CBC_Encrypt failure in tdbEncryptPage\n- remove dead pKey variable and tdbFree(pKey) call in tdbTbOpen\n- use tdbOsFree instead of taosMemoryFree in tdbTbcOpen error path\n- release page lock on CBC_Decrypt failure in tdbPagerInitPage\n- propagate error from tdbTbPopFreePage in tdbPagerRemoveFreePage\n- add overflow array bounds check in tdbPageInsertCell\n- use portable %td format for ptrdiff_t in tdbPageCopy\n- return error on page lock init failure in tdbPageCreate\n- log pointer before freeing in tdbPageDropCell\n- add missing parentheses in TDB_O_RDWR macro\n- free aCellIdx on early return in tdbPageDefragment\n- remove stale commented-out debug logging
- tdbPagerOpen: free pager and close fd on all failure paths (fd invalid, file-id generation, getFileSize) - tdbPagerBegin: close jfd and remove journal file on hashset creation failure - tdbPagerAbort/tdbPagerRestore: validate pgno from journal against dbOrigSize to guard against corruption - tdbPagerFetchPage: release page refcount on init failure, uninitialized page, and pager mismatch error paths - tdbPagerFetchFreePage: release page refcount on init failure - Remove stale commented-out debug code
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a series of issues across the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini review |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Description
Issue(s)
Checklist
Please check the items in the checklist if applicable.