Skip to content

DOUBLE (edit: was REMOVE) the line-length limit in Find-result window #7723

@sasumner

Description

@sasumner

Description of the Issue

There has been a complaint about long lines not being "well-represented" in the Find result window. See https://notepad-plus-plus.org/community/topic/18028/how-do-i-see-the-full-line-in-find-results-window.

Long lines are truncated and an ellipsis appended if the line is too long. If the "hit" for the line occurs in the truncated part, the hit marking is either not present, or is sometimes put in a questionable location.

The line-length limit is represented by SC_SEARCHRESULT_LINEBUFFERMAXLENGTH which resolves to 1024. This #define comes from a Scintilla #include but there doesn't seem to be any rationale for it; perhaps it is a vestige from the early days?

Removing the line-length limit would solve the problem, but would it create any new problems?

Steps to Reproduce the Issue

See the Community issue linked earlier.

Expected Behavior

Hits beyond column (roughly) 1024 should have their matched hit-text fully visible in the Find-result window.

Actual Behavior

Lines with length greater than (roughly) 1024 are truncated and a ... is appended to the end. Thus, the true hit text is not knowable from simply looking at the line in Find-result. Note that if one double-clicks the line in Find-result, the true hit-text will be revealed because the user's caret selection will indicate it in an editor tab.

Debug Information

Notepad++ v7.8 (32-bit)
Build time : Oct 7 2019 - 00:58:16
Path : C:........\npp.7.8.bin\notepad++.exe
Admin mode : OFF
Local Conf mode : ON
OS Name : Windows 10 Enterprise (64-bit)
OS Version : 1709
OS Build : 16299.1508
Plugins : ColumnTools.dll Explorer.dll LocationNavigate.dll MarkdownViewerPlusPlus.dll mimeTools.dll NppConverter.dll NppExec.dll NppExport.dll PythonScript.dll

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions