[BUG] Regression in 8.7 : Find dialog status bar messaging #15662
Description
Is there an existing issue for this?
- I have searched the existing issues
Description of the Issue
See below.
Steps To Reproduce
- Consider (otherwise empty) document containing
abc abc. - Place the caret on the first
abc. - Invoke Ctrl+f checkmark the box for Wrap around and uncheckmark Backward direction.
- Press Find Next until the status bar indicates "Find: Found the last occurrence from the top. The end of the document has been reached."
Current Behavior
The problem with this is that what is selected is now the first occurrence from the top, not the last occurrence from the top (as the status messaging says).
This is purely a problem with the messaging, not the searching logic.
Here's the regressive text, from english.xml :
<find-status-top-reached value="Find: Found the last occurrence from the bottom. The beginning of the document has been reached."/>
<find-status-end-reached value="Find: Found the last occurrence from the top. The end of the document has been reached."/>
<find-status-replace-top-reached value="Replace: Replaced the last occurrence from the bottom. The begin of document has been reached"/>
<find-status-replace-end-reached value="Replace: Replaced the last occurrence from the top. The end of document has been reached"/>
Expected Behavior
I'd expect better status messages.
Generally, in 8.7, the texts "Find: Found the 1st occurrence" and "Replace: Replaced the 1st occurrence" have been replaced with "Find: Found the last occurrence" and "Replace: Replaced the last occurrence", respectively. And this is bad...
Even if this regression was not introduced, couldn't these texts be made better?
Instead of (the non-regressive 8.6.9 text):
<find-status-end-reached value="Find: Found the 1st occurrence from the top. The end of the document has been reached."/>
<find-status-top-reached value="Find: Found the 1st occurrence from the bottom. The beginning of the document has been reached."/>
<find-status-replace-end-reached value="Replace: Replaced the 1st occurrence from the top. The end of document has been reached"/>
<find-status-replace-top-reached value="Replace: Replaced the 1st occurrence from the bottom. The begin of document has been reached"/>
I'd suggest:
<find-status-end-reached value="Find: Found the first occurrence in the document (the bottom was reached and "Wrap around" to top occurred)"/>
<find-status-top-reached value="Find: Found the last occurrence in the document (the top was reached and "Wrap around" to bottom occurred)"/>
<find-status-replace-end-reached value="Replace: Replaced the last occurrence in the document (then "Wrap around" to top occurred)"/>
<find-status-replace-top-reached value="Replace: Replaced the first occurrence in the document (then "Wrap around" to bottom occurred)"/>
The suggested new text also informs the user what Wrap around means (many novice users are confused on this point).
Debug Information
Notepad++ v8.7 (64-bit)
Build time : Sep 17 2024 - 17:06:31
Path : C:\NotepadPlusPlus\Misc\_NoBackup\Releases\npp.8.7\npp.8.7.portable.x64\notepad++.exe
Command Line : -titleAdd="8.7 64-bit" -multiInst "C:\NotepadPlusPlus\Temp\20240928-055958_.txt" -n12
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
Periodic Backup : ON
OS Name : Windows 11 Pro (64-bit)
OS Version : 23H2
OS Build : 22631.4169
Current ANSI codepage : 1252
Plugins :
mimeTools (3.1)
NppConverter (4.6)
NppExport (0.4)Anything else?
No response