-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Description
Description of the Issue
Scintilla/Lexilla's LexPerl has changed significantly since the stylers.model.xml list of styles for Perl was created/last-updated, so it is now out-of-date, and Notepad++ isn't settings colors for all the styles that are available in LexPerl.
stylers.model.xmldefines three styles (PREPROCESSOR, PUNCTUATION, LONGQUOTE) that aren't used by LexPerl.stylers.model.xmlis missing 24 styles that are used by LexPerl.- Some of the names for the styles should be updated for clarity.
I will be submitting a PR that includes the updates to the style list for both stylers.model.xml and themes\DarkModeDefault.xml, with colors that are reasonable for those default themes.
For the other themes that ship with Notepad++, I was thinking of setting colorStyle="0" for the new styles, so that they will inherit the foreground and background from their theme, to avoid defining colors that clash with the theme (it will mean that users who use those themes will not notice any changes in syntax highlighting, but if they go to Style Configurator, they will see more Styles available to Perl). But if someone disagrees and thinks I should leave the other themes alone, I won't bother.