Skip to content

Untie _UpdateCommandsForPalette and _RefreshUIForSettingsReload #9256

@zadjii-msft

Description

@zadjii-msft
            // Make sure to _UpdateCommandsForPalette before
            // _RefreshUIForSettingsReload. _UpdateCommandsForPalette will make
            // sure the KeyChordText of Commands is updated, which needs to

Huh. Really. That's a weird dependency.

Please file a followup task to .. i dunno, make the settings model standalone or something? It seems like it still can't work without Page around :|

Originally posted by @DHowett in #9253 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Area-SettingsUIAnything specific to the SUIIssue-TaskIt's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions