From 134bcd5f8b40d4ecea09b1966fc65b401cde6aec Mon Sep 17 00:00:00 2001 From: Kanstantsin Shautsou Date: Fri, 22 Jul 2016 01:05:02 +0300 Subject: [PATCH 1/7] debug single test --- .travis/travis-before-install.sh | 2 +- pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis/travis-before-install.sh b/.travis/travis-before-install.sh index 13034fc74..e6fc2a344 100755 --- a/.travis/travis-before-install.sh +++ b/.travis/travis-before-install.sh @@ -29,7 +29,7 @@ sudo -E apt-cache policy docker-engine # sudo dpkg -i "$(ls *${DOCKER_VERSION}*)" #popd #rm -f "src/test/resources/logback.xml" -mv "src/test/resources/travis-logback.xml" "src/test/resources/logback.xml" +#mv "src/test/resources/travis-logback.xml" "src/test/resources/logback.xml" echo 'DOCKER_OPTS="-H=unix:///var/run/docker.sock -H=tcp://127.0.0.1:2375"' | sudo tee -a /etc/default/docker sudo -E restart docker diff --git a/pom.xml b/pom.xml index 130977ba3..41f31a687 100644 --- a/pom.xml +++ b/pom.xml @@ -405,7 +405,7 @@ integration integration-auth - **/*Test.java + **/AttachContainerCmdExecTest.java From edd4f5031fc7604f8b424e2d8a6d563a3624d1c9 Mon Sep 17 00:00:00 2001 From: Kanstantsin Shautsou Date: Fri, 22 Jul 2016 02:08:13 +0300 Subject: [PATCH 2/7] fix concurrency issue --- .../exec/AttachContainerCmdExecTest.java | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/src/test/java/com/github/dockerjava/netty/exec/AttachContainerCmdExecTest.java b/src/test/java/com/github/dockerjava/netty/exec/AttachContainerCmdExecTest.java index 675c11177..7daa59b25 100644 --- a/src/test/java/com/github/dockerjava/netty/exec/AttachContainerCmdExecTest.java +++ b/src/test/java/com/github/dockerjava/netty/exec/AttachContainerCmdExecTest.java @@ -1,5 +1,6 @@ package com.github.dockerjava.netty.exec; +import static java.util.concurrent.TimeUnit.SECONDS; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.containsString; import static org.hamcrest.Matchers.isEmptyString; @@ -70,7 +71,7 @@ public void onNext(Frame frame) { }; dockerClient.attachContainerCmd(container.getId()).withStdErr(true).withStdOut(true).withFollowStream(true) - .withLogs(true).exec(callback).awaitCompletion(10, TimeUnit.SECONDS); + .withLogs(true).exec(callback).awaitCompletion(10, SECONDS); callback.close(); assertThat(callback.toString(), containsString(snippet)); @@ -81,33 +82,40 @@ public void attachContainerWithStdin() throws Exception { String snippet = "hello world"; - CreateContainerResponse container = dockerClient.createContainerCmd("busybox").withCmd("/bin/sh", "-c", "read line && echo $line") - .withTty(false).withStdinOpen(true).exec(); + CreateContainerResponse container = dockerClient.createContainerCmd("busybox") + .withCmd("/bin/sh", "-c", "sleep 1 && read line && echo $line") + .withTty(false) + .withStdinOpen(true) + .exec(); LOG.info("Created container: {}", container.toString()); assertThat(container.getId(), not(isEmptyString())); dockerClient.startContainerCmd(container.getId()).exec(); + Thread.sleep(SECONDS.toMillis(3)); //wait bash initialisation + InspectContainerResponse inspectContainerResponse = dockerClient.inspectContainerCmd(container.getId()).exec(); assertTrue(inspectContainerResponse.getState().getRunning()); AttachContainerTestCallback callback = new AttachContainerTestCallback() { - @Override public void onNext(Frame frame) { assertEquals(frame.getStreamType(), StreamType.STDOUT); super.onNext(frame); - }; + } }; InputStream stdin = new ByteArrayInputStream((snippet + "\n").getBytes()); - dockerClient.attachContainerCmd(container.getId()).withStdErr(true).withStdOut(true).withFollowStream(true) + dockerClient.attachContainerCmd(container.getId()) + .withStdErr(true) + .withStdOut(true) + .withFollowStream(true) .withStdIn(stdin) .exec(callback) - .awaitCompletion(5, TimeUnit.SECONDS); + .awaitCompletion(15, SECONDS); callback.close(); assertThat(callback.toString(), containsString(snippet)); @@ -141,7 +149,7 @@ public void onNext(Frame frame) { .withStdOut(true) .withFollowStream(true) .exec(callback) - .awaitCompletion(10, TimeUnit.SECONDS); + .awaitCompletion(10, SECONDS); callback.close(); // HexDump.dump(collectFramesCallback.toString().getBytes(), 0, System.out, 0); From 8b51dad558b5cb9e300dc126d427cc173cb578cd Mon Sep 17 00:00:00 2001 From: Kanstantsin Shautsou Date: Fri, 22 Jul 2016 02:25:44 +0300 Subject: [PATCH 3/7] try debug --- .travis.yml | 12 ++++++------ .travis/travisci_build_coverity_scan.sh | 2 ++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index a8cbe29e2..26329e6f5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -17,15 +17,15 @@ env: # via the "travis encrypt" command using the project repo's public key - secure: "GonzmzvnXsTNQV+6sKtBSSPiwbpMZjxumNt5LFp1g77/afLxw9kl2EQOXbUe308vFOwRVqeY7drBvNJa8aJkTUClfMaGRjfZ9DUwm6doMKMUYrdEkYoQTcH7yDX5K5w9MT6m+Izj+BK2gB7nK3yFlYG6COeXCdFbQ4/cf3/xfRc=" - COVERITY_SCAN_PROJECT_NAME="docker-java/docker-java" - - COVERITY_SCAN_BRANCH_PATTERN="master" + - COVERITY_SCAN_BRANCH_PATTERN="kostyasha/debugTravis" - COVERITY_SCAN_NOTIFICATION_EMAIL="kanstantsin.sha@gmail.com" matrix: - - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="1.11.2-0~trusty" DEPLOY=true CODECOV=true - - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="1.11.2-0~trusty" DEPLOY=true COVERITY=true CODECOV=true - - repo="main" DOCKER_HOST="unix:///var/run/docker.sock" DOCKER_VERSION="1.11.2-0~trusty" - - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="1.10.3-0~trusty" - - repo="main" DOCKER_HOST="unix:///var/run/docker.sock" DOCKER_VERSION="1.10.3-0~trusty" +# - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="1.11.2-0~trusty" DEPLOY=true CODECOV=true + - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="1.11.2-0~trusty" DEPLOY=false COVERITY=true CODECOV=true +# - repo="main" DOCKER_HOST="unix:///var/run/docker.sock" DOCKER_VERSION="1.11.2-0~trusty" +# - repo="main" DOCKER_HOST="tcp://127.0.0.1:2375" DOCKER_VERSION="1.10.3-0~trusty" +# - repo="main" DOCKER_HOST="unix:///var/run/docker.sock" DOCKER_VERSION="1.10.3-0~trusty" # - repo="testing" DOCKER_HOST="tcp://127.0.0.1:2375" # - repo="testing" DOCKER_HOST="unix:///var/run/docker.sock" # - repo="experimental" DOCKER_HOST="tcp://127.0.0.1:2375" diff --git a/.travis/travisci_build_coverity_scan.sh b/.travis/travisci_build_coverity_scan.sh index 6bf9a9b1f..f1cd3d261 100755 --- a/.travis/travisci_build_coverity_scan.sh +++ b/.travis/travisci_build_coverity_scan.sh @@ -52,6 +52,8 @@ fi mkdir -p /tmp/coverity-cache || : if [ ! -d $TOOL_BASE ]; then + file $TOOL_ARCHIVE | grep HTML && rm -f $TOOL_ARCHIVE || echo "$TOOL_ARCHIVE not html" + # Download Coverity Scan Analysis Tool if [ ! -e $TOOL_ARCHIVE ]; then echo -e "\033[33;1mDownloading Coverity Scan Analysis Tool...\033[0m" From f8d19e0bf7e604f2616f29e19a210c730af2b2e4 Mon Sep 17 00:00:00 2001 From: Kanstantsin Shautsou Date: Fri, 22 Jul 2016 02:29:50 +0300 Subject: [PATCH 4/7] try debug --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 26329e6f5..e4131c48d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -17,7 +17,7 @@ env: # via the "travis encrypt" command using the project repo's public key - secure: "GonzmzvnXsTNQV+6sKtBSSPiwbpMZjxumNt5LFp1g77/afLxw9kl2EQOXbUe308vFOwRVqeY7drBvNJa8aJkTUClfMaGRjfZ9DUwm6doMKMUYrdEkYoQTcH7yDX5K5w9MT6m+Izj+BK2gB7nK3yFlYG6COeXCdFbQ4/cf3/xfRc=" - COVERITY_SCAN_PROJECT_NAME="docker-java/docker-java" - - COVERITY_SCAN_BRANCH_PATTERN="kostyasha/debugTravis" + - COVERITY_SCAN_BRANCH_PATTERN="kostyasha\/debugTravis" - COVERITY_SCAN_NOTIFICATION_EMAIL="kanstantsin.sha@gmail.com" matrix: From 8f1ed0b3a42b398da62b58fef73b851c11f8a476 Mon Sep 17 00:00:00 2001 From: Kanstantsin Shautsou Date: Fri, 22 Jul 2016 03:12:05 +0300 Subject: [PATCH 5/7] limit fork --- pom.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pom.xml b/pom.xml index 41f31a687..52281a24e 100644 --- a/pom.xml +++ b/pom.xml @@ -402,6 +402,8 @@ verify + methods + 6 integration integration-auth From 56ae9f58d78e916028e2ed8dded1f576067b1602 Mon Sep 17 00:00:00 2001 From: Kanstantsin Shautsou Date: Fri, 22 Jul 2016 03:14:32 +0300 Subject: [PATCH 6/7] limit fork --- pom.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 52281a24e..2f6641737 100644 --- a/pom.xml +++ b/pom.xml @@ -403,7 +403,9 @@ methods - 6 + true + true + 1 integration integration-auth From 23816df262acdc57433792aa0487025b7cada656 Mon Sep 17 00:00:00 2001 From: Kanstantsin Shautsou Date: Fri, 22 Jul 2016 11:47:29 +0300 Subject: [PATCH 7/7] SearchImagesCmdExecTest --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 2f6641737..fa5986758 100644 --- a/pom.xml +++ b/pom.xml @@ -409,7 +409,7 @@ integration integration-auth - **/AttachContainerCmdExecTest.java + **/SearchImagesCmdExecTest.java