Message 67062 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	belopolsky
Recipients	belopolsky, benjamin.peterson, georg.brandl, gvanrossum
Date	2008-05-19.14:43:45
SpamBayes Score	0.5414322
Marked as misclassified	No
Message-id	<1211208237.87.0.982558004934.issue2897@psf.upfronthosting.co.za>
In-reply-to

Content
Note that structmember.h pollutes global namespace with macros that do not have conventional Py_ or PY_ prefix. READONLY and RESTRICTED macros seem to be most likely to conflict with other code. I would be -0 on including tructmember.h in Python.h if flags macros are not properly renamed. +0 otherwise. T_* macros are probably OK, but T prefix is reminiscent of popular (in some circles) Taligent naming conventions: http://pcroot.cern.ch/TaligentDocs/TaligentOnline/DocumentRoot/1.0/Docs/bo oks/WM/WM_63.html#HEADING77

Note that structmember.h pollutes global namespace with macros that do not  
have conventional Py_ or PY_ prefix.  READONLY and RESTRICTED macros seem 
to be most likely to conflict with other code.  I would be -0 on including tructmember.h in Python.h if flags macros are not properly renamed.  +0 
otherwise.  T_* macros are probably OK, but T prefix is reminiscent of 
popular (in some circles) Taligent naming conventions:

http://pcroot.cern.ch/TaligentDocs/TaligentOnline/DocumentRoot/1.0/Docs/bo
oks/WM/WM_63.html#HEADING77

History
Date	User	Action	Args
2008-05-19 14:44:01	belopolsky	set	spambayes_score: 0.541432 -> 0.5414322 recipients: + belopolsky, gvanrossum, georg.brandl, benjamin.peterson
2008-05-19 14:43:59	belopolsky	set	spambayes_score: 0.541432 -> 0.541432 messageid: <1211208237.87.0.982558004934.issue2897@psf.upfronthosting.co.za>
2008-05-19 14:43:55	belopolsky	link	issue2897 messages
2008-05-19 14:43:53	belopolsky	create