This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.araujo
Recipients belopolsky, benjamin.peterson, brandon-rhodes, daniel.urban, eric.araujo, ncoghlan, pitrou
Date 2011-03-19.13:36:44
SpamBayes Score 0.00039444858
Marked as misclassified No
Message-id <1300541804.99.0.135380035012.issue11572@psf.upfronthosting.co.za>
In-reply-to
Content
Nice cleanup.

-            reductor = getattr(x, "__reduce__", None)
-            if reductor:
-                rv = reductor()
-            else:
-                raise Error("un(shallow)copyable object of type %s" % cls)
+            raise Error("un(shallow)copyable object of type %s" % cls)
Why change this?

>         self.assertTrue(issubclass(copy.Error, Exception))
You could change that to assertIsInstance.

> -def _test():
I assume that all cases that were tested in that function are covered by unit tests.
History
Date User Action Args
2011-03-19 13:36:45eric.araujosetrecipients: + eric.araujo, ncoghlan, belopolsky, pitrou, benjamin.peterson, daniel.urban, brandon-rhodes
2011-03-19 13:36:44eric.araujosetmessageid: <1300541804.99.0.135380035012.issue11572@psf.upfronthosting.co.za>
2011-03-19 13:36:44eric.araujolinkissue11572 messages
2011-03-19 13:36:44eric.araujocreate